search

d2l-ai / d2l-en

Interactive deep learning book with multi-framework code, math, and discussions. Adopted at 500 universities from 70 countries including Stanford, MIT, Harvard, and Cambridge.
https://D2L.ai
Other
22.62k stars 4.2k forks source link

Fix attention-pooling.md Kernels and Data plot display issue #2514

Closed maxwillzq closed 1 year ago

maxwillzq commented 1 year ago

Without plt.show(), it has display issue.

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

github-actions[bot] commented 1 year ago

Job PR-2514-e8e2e14 is done. Check the results at http://preview.d2l.ai/d2l-en/PR-2514/e8e2e14

maxwillzq commented 1 year ago

@astonzhang, PTAL

github-actions[bot] commented 1 year ago

Job PR-2514-133106e is done. Check the results at http://preview.d2l.ai/d2l-en/PR-2514/133106e

AnirudhDagar commented 1 year ago

It turns out a better way would be to move fig, axes = d2l.plt.subplots(1, 4, sharey=True, figsize=(12, 3)) with the actual plotting code. I'll keep d2l.plt.show for the overall completeness. Thanks!

github-actions[bot] commented 1 year ago

Job PR-2514-940811a is done. Check the results at http://preview.d2l.ai/d2l-en/PR-2514/940811a

maxwillzq commented 1 year ago

Thanks a lot for your quick action. That is good!