Closed cclauss closed 4 years ago
One down, four to go.
.
We have fixed the missing imports. For the remaining flake8 style issues, we'll fix in the end
$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
./d2l/d2l.py:1654:24: F821 undefined name 'vocab'
premise = np.array(vocab[premise],
^
./d2l/d2l.py:1656:27: F821 undefined name 'vocab'
hypothesis = np.array(vocab[hypothesis],
^
2 F821 undefined name 'vocab'
2
Fixed in #953
flake8 testing of https://github.com/d2l-ai/d2l-en on Python 3.8.0
$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
https://flake8.pycqa.org/en/latest/user/error-codes.html
On the flake8 test selection, this PR does not focus on "style violations" (the majority of flake8 error codes that psf/black can autocorrect). Instead these tests are focus on runtime safety and correctness: