search

d2l-ai / d2l-tr

Kod, matematik, çoklu-çerçeveler ve tartışmalar içeren etkileşimli derin öğrenme kitabı. 55 ülkede Stanford, MIT, Harvard, and Cambridge dahil 300 üniversitede kullanılmaktadır.
https://tr.d2l.ai
Other
78 stars 14 forks source link

Updated linear networks to v0.17.1 #40

Closed semercim closed 2 years ago

semercim commented 2 years ago

Değişikliklerin açıklaması:

Bu çekme talebini göndererek, bu katkıyı tercih ettiğiniz şartlar altında kullanabileceğinizi, değiştirebileceğinizi, kopyalayabileceğinizi ve yeniden dağıtabileceğinizi onaylıyorum.

semercim commented 2 years ago

Hi @AnirudhDagar,

I had already made these changes with commit a99a314103a7c4783319732d5ecc87b8690cc83f in my feature branch. I also have the svg image files in the img folder. I checked them again, but I do not think the issues are related to these two specific images files (I keep both versions: chain-net1&2 and ChainSet1&2) in the multivariable-calculus md file. They look OK.

I also checked whether I have a missing svg file that is referred from the appendix for maths chapter but I could not detect any missing svg issue.

I would be glad if you could have a deeper look into this problem to help me. Thanks,

AnirudhDagar commented 2 years ago

I'm looking into the problem. On a side note, are the changes to Jenkinsfile intentional?

mli commented 2 years ago

Job d2l-tr/PR-40/13 is complete. Check the results at http://preview.d2l.ai/d2l-tr/PR-40/

AnirudhDagar commented 2 years ago

Should be fixed now!

mli commented 2 years ago

Job d2l-tr/PR-40/14 is complete. Check the results at http://preview.d2l.ai/d2l-tr/PR-40/

semercim commented 2 years ago

Should be fixed now!

Thanks @AnirudhDagar . Everything seems all right now. Merging the branch and closing the PR.