d2ndjim / PortFolio

This is a personal portfolio that describes projects done by the author and also describes information about the author
5 stars 0 forks source link

Code redundancy and tweaks #4

Open tkz96 opened 2 years ago

tkz96 commented 2 years ago

Hello @d2ndjim.

Great job on the portfolio. I can see that it is really coming together. As we discussed on the call with @ciragnenicole @kosher9, we want to point out a few tiny things that will help clean everything up.

I want to start by saying that the idea to separate the desktop and mobile CSS files is genius because it will be much easier to maintain. I noticed that there were some code that wasn't needed or redundant such as the * class and body class having the same code.

Also, you were using two different font families, Playfair Display and Poppins. I think your template only uses Playfair Display.

No comments other than that. Keep up the great work!