search

d2phap / ImageGlass

🏞 A lightweight, versatile image viewer
https://imageglass.org
Other
7.9k stars 501 forks source link

Unhelpful error message for images with "hidden" attribute #481

Open Thunderbolt32 opened 5 years ago

Thunderbolt32 commented 5 years ago

Prerequisites

System information:

To Reproduce

Steps to reproduce the behavior:

  1. install ImageGlass
  2. set ImageGlass as standard program for PNG images
  3. enable the display of "hidden" NTFS files in Windows Explorer
  4. double-click on a hidden PNG image in Windows Explorer so that ImageGlass opens to display it.

Actual behavior:

  1. Case 1 for SMB network drive: black image/background of dark theme
  2. Case 2 with local hard drive: "ImageGlass cannot open this image because the file is damaged, incorrect or not supported" better said the german original description "ImageGlass kann dieses Bild nicht öffnen da die Datei beschädigt ist, fehlerhaft oder nicht unterstützt wird."

Expected behavior:

  1. Option A: The image is displayed like any other. (maybe the function "Show hidden images" is automatically activated temporarily.)
  2. Option B: An error message also appears via a SMB network drive. The error message should point to the "Show hidden images" feature in both cases.

Screenshots:

default: 2018-12-31_12h38_28 "hidden"-Attribute on local hard drive 2018-12-31_12h38_51 "hidden"-Attribute on network drive 2018-12-31_12h50_16

Additional context:

See #187 and #441 Behavior was not validated with NFS network drives supported by Windows 10 Pro.

fire-eggs commented 5 years ago

A slight clarification. The blank screen will appear for either the local/network drive, if the hidden image is the only image in the folder.

The "image is corrupt" error will appear for either the local/network drive, if there are additional, non-hidden, images in the folder.

Thunderbolt32 commented 5 years ago

Ah! Right. You are right, although not completely.

If there is only one picture in the same folder, which is not "hidden", then the error message is displayed. If all images in the folder are hidden, no error message will be displayed.

fire-eggs commented 5 years ago

OK, I'll check these other scenarios! Thanks!