search

d2phap / ImageGlass

🏞 A lightweight, versatile image viewer
https://imageglass.org
Other
7.54k stars 491 forks source link

Some gifs, when zoomed to fit/height/width/fill, pause slideshow countdown + cause toolbar bugs #875

Closed the-nelsonator closed 9 months ago

the-nelsonator commented 4 years ago

System information:

To Reproduce

Steps to reproduce the behavior:

  1. Open this gif: tendies
  2. Start slideshow (same thing happens in full screen and windowed slideshow)
  3. Open toolbar (or just use the # shortcuts for step 4)
  4. Zoom to fit/height/width/fill while still on gif

Actual behavior:

Countdown timer is paused. If you switch to auto zoom, it works normally. Also bugs out the toolbar (see screenshots)

Expected behavior:

Countdown timer to count down as normal.

Screenshots:

Don't have giffing/recording software to document the countdown pausing, let me know if it's needed.

Toolbar issues:

Toolbar is gone after going into slideshow and back out while still on bugged gif. Before opening slideshow: image After closing slideshow: image

Also even before opening, if you're zoomed to fit, hovering tooltips/help text don't show up, compare to this: image

fire-eggs commented 3 years ago

Not able to repro in Win7 (native) or Win10 (virtual machine). I'll have to leave it to Phap to see if it can be repro-ed in a native Win10.

fire-eggs commented 3 years ago

I'm using IG 7.6.9.13 and Win7 (Native) and reproducing, but not with the OP's GIF.

This is hard to repro / capture. If I start the slideshow with particular GIF file, then

  1. The F11 tooltip doesn't disappear
  2. The timer doesn't appear
  3. The countdown doesn't happen (slideshow doesn't advance)

If I manually advance the slideshow (PageDn) then it acts as normal. Then back to the first image (PageUp): the countdown does appear but doesn't change.

I do think this is similar to #344: the GIF is so CPU intensive that ImageGlass doesn't get any cycles to update the GUI / timer. With some of the GIFs I'm using, changing the size (as suggested by the OP) makes no difference.

I've put a screen recording (test.gif) and some problematic GIFs in my Google Drive. (Unfortunately, I cannot give a frame-by-frame breakdown of the recording because IG's Page Navigation does not do frame stepping.)

d2phap commented 9 months ago

Since v9 moves Slideshow to a separate window. It should be not an issue.