search

d2phap / ImageGlass

🏞 A lightweight, versatile image viewer
https://imageglass.org
Other
7.9k stars 502 forks source link

What happened to the logo icon in version 8? #926

Closed timmay7 closed 3 years ago

timmay7 commented 3 years ago

The screenshot basically tells the story. The empty space used to be occupied by the ImageGlass logo. But since upgrading to version 8, it's gone?

empty-space

Very minor, but a visual annoyance.

d2phap commented 3 years ago

Hi @d2phap It's purposely hidden in the default theme Kobe.

The new theme pack API allows user to customize and hide the logo: https://github.com/ImageGlass/theme If you select another theme pack, the logo will be back.

If you want to have the logo on the title bar with Kobe theme, you can edit its igtheme.xml file, set isshowtitlebarlogo to True: https://github.com/ImageGlass/theme/blob/master/themes/dark/Kobe/igtheme.xml#L19

timmay7 commented 3 years ago

Hi @d2phap It's purposely hidden in the default theme Kobe.

The new theme pack API allows user to customize and hide the logo: https://github.com/ImageGlass/theme If you select another theme pack, the logo will be back.

If you want to have the logo on the title bar with Kobe theme, you can edit its igtheme.xml file, set isshowtitlebarlogo to True: https://github.com/ImageGlass/theme/blob/master/themes/dark/Kobe/igtheme.xml#L19

Thanks, that worked in restoring the logo. My only suggestion is that in the case where the logo is hidden, I would left-align the text so that the area where the logo used to be is filled in. That's what made it look weird.

d2phap commented 3 years ago

Thanks @timmay7, i couldn't find a way to remove that space though. I will investigate on it.

retrue commented 3 years ago

Unfortunatelly, that is not the only icon missing. In the tasks bar there is an empty space, not icon of Imageglass or mini thumbnail of the image or anything else. See the pic. Captura de pantalla 2020-12-13 132429

d2phap commented 3 years ago

@retrue

retrue commented 3 years ago

I use ImageGlass portable. Yes, it happens every time. Installed theme is Kobe. I followed your instructions, changed to Light Gray theme and the icon in the taskbar appeared. However, if I change back to Kobe theme the icon disappears again.

d2phap commented 3 years ago

@retrue Thanks for the info, there is a temporary solution, you can open igtheme.xml file of Kobe theme, set isshowtitlebarlogo to True:

https://github.com/ImageGlass/theme/blob/master/themes/dark/Kobe/igtheme.xml#L19

retrue commented 3 years ago

That worked, thanks.