search

d3 / d3-delaunay

Compute the Voronoi diagram of a set of two-dimensional points.
https://d3js.org/d3-delaunay
ISC License
611 stars 57 forks source link

upgrade to delaunator@3 #59

Closed Fil closed 5 years ago

Fil commented 5 years ago

fixes https://github.com/d3/d3-delaunay/issues/50

Demos:

I had to disable the tests for outeredges, because I'm not using the same outeredges (but they do point to the same nodes).(fixed, see below)

Fil commented 5 years ago

I've now restored the outedges as they used to be; in the following schema:

hull[i-1] -in-> p --> hull[i+1] -out-> hull[i+2]

the outeredge for p = hull[i] is the inedge for hull[i+2]

But this is imho too complicated for what we want (to be able to compute the last neighbor of p when p is on the hull). We can do so with a much more readable hullIndex (see branch hullIndex and specifically https://github.com/d3/d3-delaunay/commit/cf26755874c6e34af9451d964e8c708c9bd0a812).

So I'd be in favor of removing delaunay.outedges from the API and using hullIndex instead.

In any event, it's a major version change because delaunay.hull is not the linked chain of objects.

Fil commented 5 years ago

superseded by https://github.com/d3/d3-delaunay/pull/60