search

d3 / d3-force

Force-directed graph layout using velocity Verlet integration.
https://d3js.org/d3-force
ISC License
1.82k stars 377 forks source link

Breaking regression in v5.8.0 #135

Closed rkirsling closed 5 years ago

rkirsling commented 5 years ago

Although it was part of a minor release, #124 is a breaking change.

In particular, if we follow the docs and set fx and fy to null upon drag end (as in Force Dragging III), then we're in for some absurd behavior when we call simulation.nodes on our next data update. (See Directed Graph Editor for a complete example.)

Setting them to undefined does work, since isNaN(undefined) is false while isNaN(null) is true.

rkirsling commented 5 years ago

Thanks a bunch for the quick fix!