d3 / d3-geo-polygon

Clipping and geometric operations for spherical polygons.
https://d3.observablehq.cloud/d3-geo-polygon/
Other
113 stars 23 forks source link

Use text for source & example links. #29

Closed mbostock closed 5 years ago

mbostock commented 5 years ago

I feel this is both more self-evident and easier to maintain.

Fil commented 5 years ago

Yes!

I would just change to singular [Example], even when there are several:

mbostock commented 5 years ago

I’m okay capitalizing, but I think examples plural is appropriate because in the common case there will be more than one example.

Fil commented 5 years ago

Sorry I did not mean to capitalize, it was a slip of the keyboard. But come to think of it it looks good :)

My only concern is that this [Source] [Examples] part is now more visible than the function's name. Maybe <small> like in the first line of the simulation below?

Capture d’écran 2019-05-10 à 21 55 43

Also, why the rel-nofollow?

Fil commented 5 years ago

(PS: don't bother applying whichever style to the whole file, at the end of this process I'll clean up and push a single commit.)

mbostock commented 5 years ago

GitHub sanitizes the styles, so <small> doesn’t work, sadly. (See test.)

mbostock commented 5 years ago

Made a few more typographic adjustments, but the design space is pretty limited by GitHub here.

Fil commented 5 years ago

Merged in https://github.com/d3/d3-geo-polygon/commit/2a18595b50d1ed28dfbedb76db687faae134f60a