search

d3 / d3-geo-projection

Extended geographic projections for d3-geo.
https://observablehq.com/collection/@d3/d3-geo-projection
Other
1.1k stars 201 forks source link

fixes armadillo inverse #189

Closed Fil closed 4 years ago

Fil commented 4 years ago

(see https://observablehq.com/@fil/armadillo-glsl?collection=@fil/projections)

mbostock commented 4 years ago

I can’t see any effect from enabling or disabling the new line of code in the shader, but I assume you know what you’re doing, so 👍 .

Fil commented 4 years ago

This particular issue didn't show for the default parallel = 20° but for higher parallels I had this:

Capture d’écran 2020-04-07 à 22 10 03

this issue also has the consequence that dragging in those areas results in awful jumps.

I haven't found how to fix the tiny bug at the top corners for phi0 between 20° and 30°.

(Though I don't want to burden you with a review of these small things, I'm always happy to have more eyeballs on my changes.)