search

d3 / d3-scale-chromatic

Sequential, diverging and categorical color scales.
https://d3js.org/d3-scale-chromatic
Other
802 stars 106 forks source link

Add improved Tableau color scheme, permission granted by Tableau #18

Closed akngs closed 5 years ago

akngs commented 6 years ago

Almost same with #16 but with the Tableau citation more explicit, which is the Tableau legal team's requirement.

curran commented 6 years ago

Interestingly, it appears category10 is the original Tableau color scheme.

image

From How we designed the new color palettes in Tableau 10

akngs commented 6 years ago

Interestingly, it appears category10 is the original Tableau color scheme.

Yes, indeed. Tableau's original color scheme is in use virtually everywhere since its inception. Various packages of R and Python also use the same color set, but I don't see a clear reason why it is so popular.

mbostock commented 6 years ago

For D3, the provenance starts with Prefuse Flare:

https://github.com/prefuse/Flare/blob/1166bcf5516bf2ee12be0ca37fe206ae07b825d2/flare/src/flare/util/palette/ColorPalette.as#L57-L61

Which was ported to Protovis:

https://github.com/mbostock/protovis/blob/fe258ac630b2107b6acc1156cab91a6ba29d2090/src/color/Colors.js#L50-L56

Which was ported to D3:

https://github.com/d3/d3/blob/8da80dcc994ef660198b5cf2b88343c429296847/src/scale/category.js#L22-L25

And which now lives in d3-scale-chromatic:

https://github.com/d3/d3-scale-chromatic/blob/f8d13955d2c20b2f1ee7a20fe795096ad55a012a/src/categorical/category10.js#L3

akngs commented 6 years ago

For D3, the provenance starts with Prefuse Flare:

Thank you for the explanation. I've always wondered where did the color set came from.

According to the post from Tableau, they used the scheme since version 1.5, which was released in 2005 according to this article.

Prefuse released "Prefuse flare" in 2007, but the alpha version of Prefuse itself was released in 2004! It could be the original, but I'm not sure if the scheme was there at that time.

Anyways, do you think the legal issue of this PR has been addressed appropriately by mentioning Tableau explicitly, which was the only request of Tableau legal team?

mbostock commented 6 years ago

Tableau is the original—Jeff Heer (the author of Prefuse and Prefuse Flare) was an intern at Tableau.

curran commented 6 years ago

Any thoughts regarding mergeability of this PR?

mbostock commented 5 years ago

Thanks for the PR! And apologies for the delay. 😄