d3 / d3-scale-chromatic

Sequential, diverging and categorical color scales.
https://d3js.org/d3-scale-chromatic
Other
801 stars 106 forks source link

Build error in 1.5.4 #50

Closed elijasmith closed 11 months ago

elijasmith commented 11 months ago

[INFO] ERROR in node_modules/@types/d3-scale-chromatic/index.d.ts(9,41): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(9,47): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(13,37): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(13,43): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(17,36): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(17,42): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(21,37): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(21,43): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(25,38): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(25,44): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(29,38): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(29,44): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(33,35): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(33,41): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(37,35): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(37,41): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(41,35): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(41,41): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(45,40): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(45,46): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(62,49): error TS1005: '>' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(62,55): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(62,57): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(62,58): error TS1109: Expression expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(76,49): error TS1005: '>' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(76,55): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(76,57): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(76,58): error TS1109: Expression expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(90,49): error TS1005: '>' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(90,55): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(90,57): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(90,58): error TS1109: Expression expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(104,49): error TS1005: '>' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(104,55): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(104,57): error TS1005: ',' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(104,58): error TS1109: Expression expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(118,49): error TS1005: '>' expected. [INFO] node_modules/@types/d3-scale-chromatic/index.d.ts(118,55): error TS1005: ',' expected.

elijasmith commented 11 months ago

Following package.json was observed in /node_modules/@types/d3-scale-chromatic

{ "_from": "@types/d3-scale-chromatic@^1", "_id": "@types/d3-scale-chromatic@1.5.4", "_inBundle": false, "_integrity": "sha512-HwLVEm8laYTNOR9Kc9745XDKgRa69VIIChNkSKJgrJOsDLI9QSiFSH2Bi4wMbGrvFs+X64azev7NfBPq+VOFVg==", "_location": "/@types/d3-scale-chromatic", "_phantomChildren": {}, "_requested": { "type": "range", "registry": true, "raw": "@types/d3-scale-chromatic@^1", "name": "@types/d3-scale-chromatic", "escapedName": "@types%2fd3-scale-chromatic", "scope": "@types", "rawSpec": "^1", "saveSpec": null, "fetchSpec": "^1" }, "_requiredBy": [ "/@types/d3" ], "_resolved": "https://registry.npmjs.org/@types/d3-scale-chromatic/-/d3-scale-chromatic-1.5.4.tgz", "_shasum": "b067005a6b32842921bde591a8a4bf40727c50dd", "_spec": "@types/d3-scale-chromatic@^1", "_where": "/opt/jenkins/workspace/Portal-QA/angular/node_modules/@types/d3", "bugs": { "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/issues" }, "bundleDependencies": false, "contributors": [ { "name": "Hugues Stefanski", "url": "https://github.com/Ledragon" }, { "name": "Alex Ford", "url": "https://github.com/gustavderdrache" }, { "name": "Boris Yankov", "url": "https://github.com/borisyankov" }, { "name": "Henrique Machado", "url": "https://github.com/henriquefm" }, { "name": "Nathan Bierema", "url": "https://github.com/Methuselah96" } ], "dependencies": {}, "deprecated": false, "description": "TypeScript definitions for d3-scale-chromatic", "homepage": "https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/d3-scale-chromatic", "license": "MIT", "main": "", "name": "@types/d3-scale-chromatic", "repository": { "type": "git", "url": "git+https://github.com/DefinitelyTyped/DefinitelyTyped.git", "directory": "types/d3-scale-chromatic" }, "scripts": {}, "typeScriptVersion": "4.5", "types": "index.d.ts", "typesPublisherContentHash": "d7a50257a81e2146b3294aa050068baf0af38af335f103db7a691b830c845fe8", "version": "1.5.4" }

elijasmith commented 11 months ago

Something changed here from 1.5.3 -> 1.5.4 - a project that was previously building fine on 1.5.3 started failing at build time once it picked up 1.5.4. Not sure if there are other idiosyncrasies as we are using an old core-js version (2.6.12), but I was able to resolve for now by forcing this dependency to 1.5.3 (and a few other d3 ones also had to be rolled back: quadtree@1.0.12, scale@2.2.9, and shape@1.3.11)