New symbol "ecks" (x). - Githubissues

d3 / d3-shape

Graphical primitives for visualization, such as lines and areas.

https://d3js.org/d3-shape

ISC License

2.47k stars 305 forks source link

New symbol "ecks" (x). #151

Closed jarrettmeyer closed 4 years ago

jarrettmeyer commented 4 years ago

Adds ecks.js, which draws an X symbol.
Adds ecks to symbol.js.
Adds symbolEcks export to index.js.
Adds supporting unit tests.

Fil commented 4 years ago

I built your branch (d3-shape.js), and integrated it in https://observablehq.com/@fil/drag-symbols — but it didn't change much. I then realized that ecks is the same symbol as cross, only with a 45° rotation. So, is it really needed?

ecks

mbostock commented 4 years ago

I agree with @Fil and think this is too similar to the existing cross symbol.