Fix curve instanceof. - Githubissues

d3 / d3-shape

Graphical primitives for visualization, such as lines and areas.

https://d3js.org/d3-shape

ISC License

2.48k stars 310 forks source link

Fix curve instanceof. #60

Closed mbostock closed 8 years ago

mbostock commented 8 years ago

The current definition does not propagate the prototype to the factory method, so instanceof d3.curveLinear and the like do not work.

[ ] Linear
[ ] Radial
[ ] Basis
[ ] BasisClosed
[ ] BasisOpen
[ ] Bundle
[ ] Cardinal
[ ] CardinalClosed
[ ] CardinalOpen
[ ] CatmullRom
[ ] CatmullRomClosed
[ ] CatmullRomOpen
[ ] LinearClosed
[ ] MonotoneX
[ ] MonotoneY
[ ] Natural
[ ] Step

mbostock commented 8 years ago

Actually, I think this is fine; these classes are anonymous, and I don’t see a strong reason to support instanceof, prototype extension, and constructor inspection.