d3 / d3-shape

Graphical primitives for visualization, such as lines and areas.
https://d3js.org/d3-shape
ISC License
2.48k stars 308 forks source link

Curves should use named parameters. #61

Closed mbostock closed 8 years ago

mbostock commented 8 years ago

For consistency with d3/d3-ease@f0ea8b55a9eb5395a15d54fe5f96c7e4934ec1b7 (though the ease.ease part was later reverted) and d3/d3-interpolate@70ebb631406397785194b7e93413db0eec6304d3, curves should also use named parameters rather than binding optional parameters in line.curve and area.curve. Specifically, code like this:

var line = d3.line().curve(d3.curveCardinal, 0.5);

Should be replaced with:

var line = d3.line().curve(d3.curveCardinal.tension(0.5));