search

d3 / d3-transition

Animated transitions for D3 selections.
https://d3js.org/d3-transition
ISC License
224 stars 65 forks source link

Remove magic transition.each inheritance. #4

Closed mbostock closed 8 years ago

mbostock commented 9 years ago

I.e., d3_transitionInheritId. Part of this involves removing d3.transition(selection[, name]). This method is too different from d3.transition([name]), the much-more frequent form.

Like d3.maybeTransition(selection[, name])? It might be better to expose the context transition within transition.each.

mbostock commented 8 years ago

Or for that matter, selection.inheritTransition([name])? I don’t see that it needs to be a top-level method given that it requires a selection; it should be a selection method.

mbostock commented 8 years ago

The brush and zoom behavior currently using d3_transitionInheritId to check whether they need to transition. So we’ll need to figure out how to fix that, too. It could be as simple as g instanceof transition.

mbostock commented 8 years ago

This feels like it’s covered by #21. I’m not going to put this magic functionality back in, and whatever we come up with for #21 should perform the same function.