search

d3 / d3-zoom

Pan and zoom SVG, HTML or Canvas using mouse or touch input.
https://d3js.org/d3-zoom
ISC License
501 stars 144 forks source link

Pin d3-selection dep to 3.0.0 #274

Open OliverMadine opened 2 months ago

OliverMadine commented 2 months ago

zoom.transform uses selection.interrupt

~which conflicts if not using d3-selection 3.0.0 onwards~

which may conflict with different versions of d3-selection installed

mbostock commented 2 months ago

That doesn’t seem right. First, selection.interrupt is provided by d3-transition, not d3-selection. And second, selection.interrupt has existed since version 0.0.5 of d3-transition; see https://github.com/d3/d3-transition/commit/46bbcd660aec3ee8c8811d57552f8f7711880dab. You probably have a different issue which is duplicate versions of d3-selection installed, preventing d3-transition from modifying d3.selection.prototype.

OliverMadine commented 2 months ago

Ah my bad, I took this comment thread at face value.

fwiw, the issue is as you described with this structure (image from here) image

Upgrading d3-selection does work, but ideally we would have a build conflict fail somewhere ☹️

preventing d3-transition from modifying selection.prototype.

I'm mostly questioning this part