Closed d33pspace closed 3 years ago
@MariiaBubley I believe this is fixed, but I only tested Behavior overview page. Can you please confirm:
Behavior overview: https://d33pspace.github.io/RenewalMgtApp-Html/app/reports_behavior_overview.html
@d33pspace Users also have to open with a tap on the user's line. https://d33pspace.github.io/RenewalMgtApp-Html/app/users_list.html
all item's lines too (in all pages https://d33pspace.github.io/RenewalMgtApp-Html/app/item_catalogue.html https://d33pspace.github.io/RenewalMgtApp-Html/app/return_page.html# https://d33pspace.github.io/RenewalMgtApp-Html/app/take_page.html
Guests too (exept right area with other functions) https://d33pspace.github.io/RenewalMgtApp-Html/app/main_page.html https://d33pspace.github.io/RenewalMgtApp-Html/app/guest_list.html
@academws Please fix tap on line response for the six additional pages here.
https://d33pspace.github.io/RenewalMgtApp-Html/app/users_list.html
https://d33pspace.github.io/RenewalMgtApp-Html/app/item_catalogue.html
https://d33pspace.github.io/RenewalMgtApp-Html/app/return_page.html#
https://d33pspace.github.io/RenewalMgtApp-Html/app/take_page.html
https://d33pspace.github.io/RenewalMgtApp-Html/app/main_page.html
https://d33pspace.github.io/RenewalMgtApp-Html/app/guest_list.html
https://d33pspace.github.io/RenewalMgtApp-Html/app/users_list.html - that's not really 'open' as I understand. It lead you to the user profile page, so it's a link. If it somehow's 'open', I need a design for that. https://d33pspace.github.io/RenewalMgtApp-Html/app/item_catalogue.html - the same https://d33pspace.github.io/RenewalMgtApp-Html/app/guest_list.html - the same https://d33pspace.github.io/RenewalMgtApp-Html/app/return_page.html - done
https://d33pspace.github.io/RenewalMgtApp-Html/app/take_page.html - I didn't think that it works so easy, because as I understand, this page will contain some functionality like "category with items inside". For now we have only front part of them, and I really didn't think we can do it now, because all this functionality is need, with backend part. I think, your developer should do this.
https://d33pspace.github.io/RenewalMgtApp-Html/app/main_page.html : in "in-service list" opens return page - as I understand, this is link too. in "finished list" opens Guest Profile - same in "waiting list" moves Guest to "in-service" list (we are discussing if animation is necessary) - done the meal icon in all lists can be tapped on individually and it changes color - done
@AnKar112 @academws Thanks for these changes! It's looking great!
https://d33pspace.github.io/RenewalMgtApp-Html/app/users_list.html https://d33pspace.github.io/RenewalMgtApp-Html/app/guest_list.html ^ For these two pages can you please link to any blank page so we can just test the tap on line functionality?
https://d33pspace.github.io/RenewalMgtApp-Html/app/item_catalogue.html ^ We are discussing logic for this page with UX designer, please wait.
https://d33pspace.github.io/RenewalMgtApp-Html/app/return_page.html ^ This looks great! But... (1) Both Trash and Lost icons cannot be active at the same time. If Trash is active and Lost is tapped, Trash becomes inactive. If Lost is active and Trash is tapped, Lost becomes inactive. (2) Unless the user taps exactly on the Trash or Lost icons, the line is tapped instead. Can we do the tap fields more like this?
https://d33pspace.github.io/RenewalMgtApp-Html/app/take_page.html ^ I understand your meaning, but in this case can we please explain the logic so you can demonstrate the UI feature? (1) If an item in the MOST COMMONLY USED list is tapped, it is added to the LAUNDRY LIST. (It also stays in the MOST COMMONLY USED list.) (2) There are two types of items that can be added from the FULL CLOTHING LIST, (a) any sub-item, (b) any item that does not have any sub-items. (a) If any sub-item in the FULL CLOTHING LIST is tapped, it is added to the LAUNDRY LIST. It also stays in the FULL CLOTHING LIST list. (b) Please remove the sub-items from Shorts in the FULL CLOTHING LIST. Shorts is an example of an item that does not have sub-items. And because it does not have sub-items, when it is tapped it is added to the LAUNDRY LIST. It also stays in the FULL CLOTHING list.
https://d33pspace.github.io/RenewalMgtApp-Html/app/main_page.html ^ You are correct about In-Service list and Finished list are links, but like above, can you please just link to a blank page so we can test the tap-on-line functionality? Also... (1) One small bug... when you tap on someone in the Waiting list to move them to the In-Service list, the meal icon cannot be made active/inactive any longer. (Also, please use full tap fields as I explained above.) (2) Please see the original Figma model you will notice the first Guest in the waiting list has a light grey background. (It is not always grey, only under certain conditions it will change color.) Can you please demonstrate the grey background? When a Guest with the light grey background is moved to the In-Service list, the background is no longer grey.
https://d33pspace.github.io/RenewalMgtApp-Html/app/users_list.html - done https://d33pspace.github.io/RenewalMgtApp-Html/app/guest_list.html - done https://d33pspace.github.io/RenewalMgtApp-Html/app/return_page.html - done https://d33pspace.github.io/RenewalMgtApp-Html/app/main_page.html - done
https://d33pspace.github.io/RenewalMgtApp-Html/app/take_page.html - not really simple task, need some time to overthink about it, will try to do it tomorrow
@AnKar112 @academws Sorry - again I'm not seeing it. Maybe didn't update the repository yet?
@AnKar112 @academws
users_list - looks good! guest_list - looks good! return_page - perfect!
main_page - small problem:
take_page - understood. please let me know if I can help you further understand the process. all we need of course is sufficient demonstration of UI features, not backend logic.
main_page - fixed
@AnKar112 @academws
All done
@AnKar112 @academws The last update to main_page says yesterday. Perhaps you need to push?
Also:
The last update to main_page says yesterday. Perhaps you need to push? - no, I wasn't changing html file, I changed JS file Change the icon on the FAB (menu in lower right) when closed should look like this (below). It means "add guest". - done
@AnKar112 @academws Icon change and Serve all button look and work great. However, still two problems...
Tap fields are still not square. It should not be possible to click/tap just outside the meal to fire the "tap on line" function.
(1) Tap on someone in Waiting List to move them to In-Service List. (2) Tap on the meal. The result is the meal icon is activated AND the return page is opened. But only the meal should be activated.
Should be ok now, check please
@AnKar112 @academws I'm so sorry I'm still seeing the problem I keep referring to. Please allow me to explain again.
Please take these exact steps on main_page to observe it: https://d33pspace.github.io/RenewalMgtApp-Html/app/main_page.html
(1) Tap on a Guest in the Waiting list to move them to the In-Service list. (2) Tap on the meal icon of the Guest that you just moved to the In-Service list.
The result is: (a) The meal icon activates, and (b) the User is directed to the return page.
Result (a) is correct, result (b) is incorrect. The User should not be directed to the return page.
I hope this makes it clear. 😊
Sorry, get you wrong last time. I mean, I found and fixed the bug last time, but it was another bug :) Fixed it too, check it please