Closed edwazhao closed 3 years ago
@edwazhao I'm not sure what's going on here. Can you check to see if changes have been made and if not, explain clearly what the issue is (and how to test using the templates, if possible).
Question from @academws Can you explain to me the logic and appearing the check and trash icon, please?
Hi @AnKar112 @academws These changes look nice, thank you!
However, for me, when the input field appears, it extends beyond the page into the grey frame. And actually, the laundry tag is maximum three characters, for example, 999. Please make the input field shorter.
Can you provide me screen resolution? I couldn't recreate inout width issue. I make max length of field 4 symbols (tag + hash)
@AnKar112 @academws I am using Firefox desktop/mobile and it does this no matter the width of the browser. In Chrome it looks good. If this is not an easy fix don't worry about it, as long as it looks good in Chrome we are good.
That's not hard, you give me all information I need :) Fixed for firefox too, check please.
@AnKar112 @academws Thank you! But no change on my end and the file doesn't seem to be updated. Maybe you didn't push the change?
Strange, it wasn't pushed. Check it again, please, now it should be ok.
@edwazhao @MariiaBubley The edit laundry tag features here look good to me. Can you confirm? By the way, more UI functionality needs to be added to this page, but that is being tracked under issue #17 .
Looks good to me, thank you
https://d33pspace.github.io/RenewalMgtApp-Html/app/take_page.html 1:
2: we need the trash icon