search

d33pspace / Renewal-Design-Html

0 stars 0 forks source link

new item page with many item types, not user-friendly #4

Closed edwazhao closed 3 years ago

edwazhao commented 3 years ago

When there are more than 10 item types in the dropdown list which is true to our system, the page's height changed a lot, is it reasonable to make a scrollbar for the dropdown list like red marked in the picture?

image

MariiaBubley commented 3 years ago

Hello, @edwazhao yes, sure! I even made relevant components in Figma, with search and without: image

d33pspace commented 3 years ago

@academws Please update the HTML templates accordingly.

edwazhao commented 3 years ago

Hi @MariiaBubley , thank you for the changes, it looks nice.

d33pspace commented 3 years ago

@edwazhao I do not see in our HTML templates which one I can test to see if this work has been done. Can you provide a link please?

d33pspace commented 3 years ago

@MariiaBubley or @edwazhao Question from FD: This function is needed only a new item page or something else?

Can we please specify where this style is used.

edwazhao commented 3 years ago

@d33pspace , yes, please check https://d33pspace.github.io/RenewalMgtApp-Html/app/new_item.html From my point of view, the scrollbar should apply for all dropdown list, while the search function only for the item type is enough

@academws , thank you for adapting it, still a minor issue, if we click Distribution Policy first, and then click Item Type, the Item Type will be covered. image

d33pspace commented 3 years ago

@academws As Edward points out above, on this page if you click on Distribution Policy then click on Item Type, the Item Type is hidden.

d33pspace commented 3 years ago

@edwazhao This is fixed. Can you confirm everything is to your liking?

d33pspace commented 3 years ago

@AnKar112 @academws This looks good but my preference would be that when one dropdown list opens, the other closes automatically. Is this possible?

edwazhao commented 3 years ago

Thanks, I will close it.