search

d33pspace / Renewal-Design-Html

0 stars 0 forks source link

Meal icon issue in give page #61

Closed edwazhao closed 2 years ago

edwazhao commented 2 years ago

https://d33pspace.github.io/RenewalMgtApp-Html/app/give_page.html

When using Phone mode, the meal icon cannot be unchecked.

image

edwazhao commented 2 years ago

Hi @d33pspace , please help to check if we need the un-check meal icon here?

d33pspace commented 2 years ago

Hi @AnKar112 How are you? I hope you're staying safe. We are all behind you.

Can you please check the issue above. Also, will you see if the Vue calendar has been updated?

AnKar112 commented 2 years ago

It works as it should - uncheck working fine. But after you uncheck it, 'finger' is still on the button, so you see hover styles https://i.imgur.com/gHMZsWD.jpg Should I delete hover styles?

Calendar - still the same

d33pspace commented 2 years ago

@AnKar112 Thanks Anton - may I ask is it possible that the Vue calendar has been deprecated? And in any case, what do you suggest if it is not updated in time? We really hope to launch the app as soon as possible.

AnKar112 commented 2 years ago

Let's try another way @edwazhao is it possible for you to use calendar throw npm? https://vcalendar.io/installation.html

d33pspace commented 2 years ago

@edwazhao Please see Anton's reply to the meal button issue as well as the calendar issue above.

edwazhao commented 2 years ago

@AnKar112,

For the current issue, if I use cell phone visit https://d33pspace.github.io/RenewalMgtApp-Html/app/give_page.html, when I uncheck the meal button, and then I need to touch somewhere else to move my 'finger' out, so that I can see the icon change, I would suggest removing hover css, same for take page please.

For the v-calendar, yes, it works with npm. And I did a commit to fix the load issue of HTML repo, please check https://d33pspace.github.io/RenewalMgtApp-Html/app/reports_operations.html

d33pspace commented 2 years ago

@AnKar112 I agree with Edward, the current design is not suitable for mobile browser. Perhaps Mariia did not understand that mobile browser is our main interface. Please fix this, and I wonder if we need to change other hover actions as well?

Also check Edward's work on the calendar. The current calendar/date-picker on the reports_operations page looks great to me!

AnKar112 commented 2 years ago

About hovers - I removed it for mobile resolutions (769px and less). So on the desktop you still have hovers. Should I check all pages for hovers?

About the calendar - great job, thank you!

edwazhao commented 2 years ago

Give page works perfect now, I would expect that all the hovers have the same behavior, could you please check other hovers?

d33pspace commented 2 years ago

@AnKar112 Yes, please check all pages for hovers and remove them for mobile resolutions. Please post a list here of the files that are changed. Thank you!

AnKar112 commented 2 years ago

forgot_password.html - button give_page.html - FAB, cards hover main_page.html - serve button password_recovery.html - button password_recovery_success.html - button reports_behavior.html, reports_item_lost.html, reports_behavior_overview.html, reports_operations.html - datepicker button, datepicker options return_page.html - buttons, fab sign_in.html, sign_up.html - button take_page.html - FAB, cards hover success.html - button

Also, I use calendar fix for all pages

d33pspace commented 2 years ago

@edwazhao Please note the pages here with updated hovers and datepickers. Please let us know if you need anything else here.

edwazhao commented 2 years ago

Everything looks good, I will close it.