d33pspace / Renewal-Design-Html

0 stars 0 forks source link

Distribution modal update #74

Closed d33pspace closed 2 years ago

d33pspace commented 2 years ago

@AnKar112 We are changing the icons on the distribution modal on the giving page according to the details here.

I believe the only change are the icons on the left column. The function here does not matter for the design - we just need the template updated.

Screenshot 2022-03-23 101702

AnKar112 commented 2 years ago
  1. About blank card (I noticed this comment https://i.imgur.com/imcOc3k.jpg ) - I made this card (it has class 'blank'), it just not displaying. You can easily turn it when you need, just off "display: none;" https://i.imgur.com/k0qD9db.jpg
  2. New icons - done
d33pspace commented 2 years ago

@AnKar112 These changes look great and thank you for pointing out the "blank" card! Closing this issue.

d33pspace commented 2 years ago

@AnKar112 I'm sorry one more thing here.

In your template, there is no example of the row with the garbage can on it, like the last row in the Figma sample above.

edwazhao commented 2 years ago

@AnKar112 Could you please make an example in the give page of just off "display: none;" you mentioned above, since the current issue could be difficult to track in the future, it is better to have the example available in the template.

BTW, to make it easy for you there is no need to fill all the Given column, because some of them could be empty. For the modal dialog, just some valuable examples is totally fine.

d33pspace commented 2 years ago

@AnKar112 Summary here:

On give_page distribution pop-up modal, please provide examples of a row with a garbage can on it (according to design in Figma, and a row with "display: none;" Even though you have already designed this row, we'd like a sample in the template.

Screenshot 2022-03-29 065130 Screenshot 2022-03-29 065156

AnKar112 commented 2 years ago

Done