d33pspace / Renewal-Design-Html

0 stars 0 forks source link

Unify search #75

Closed d33pspace closed 2 years ago

d33pspace commented 2 years ago

@AnKar112 I'm sorry I just noticed we don't have a persistent search field on guest_list or start_the_service.

Can you please implement Mariia's design on these two pages? She says this is "persistent search" by Material Design. Actually, she suggested "expandable search" for guest_list, but I want persistent search on both guest_list and start_the_service.

159881800-ea3d2b07-97a9-486c-875a-10c86943f1a6

AnKar112 commented 2 years ago

@d33pspace I should only make layout, not the functional, right? And by the way, we also have the buttons 'search' on guest list, user list, and item catalogue.

d33pspace commented 2 years ago

@AnKar112 Yes, layout only.

Let me know if you need a design for any of these. Mariia has designs for both persistent search and expandable search, but only on guest_list (expandable) and start_the_service (persistent).

AnKar112 commented 2 years ago

https://material.io/design/navigation/search.html#persistent-search - this is not really what can I do. I didn't think that material design is a guide for developers at all. As I know, devices have their own styles of search dropdown menu. Android, iOs - they have their own styles. Maybe @edwazhao knows more about that.

d33pspace commented 2 years ago

@AnKar112 Our app is a web app, not Android or iOS. Are you able to add the search start_the_service page like in Mariia's design on Figma? That is most important.

AnKar112 commented 2 years ago

Okay, I will make the layout. But I can't find dropdown styles in figma, like that https://i.imgur.com/aO3GpfA.jpg can you give me a direct link?

d33pspace commented 2 years ago

@MariiaBubley The following pages have Search, and this is how I'd like the search fields on those pages:

(1) guest_list (Persistent search) (2) start_the_service (Persistent search) (3) user_list (Expandable search) (4) item_catalogue (Remove search)

Also note that Anton needs the full design, not just reference to Material design. Including the dropdown style like this:

aO3GpfA

edwazhao commented 2 years ago

@d33pspace @academws I am not sure about the difference of Persistent search and Expandable search. For the guest_list (Persistent search), does it mean we don't load anything for the guest_list page when first go the page?

From my point of view, if user type anything in the search area below, the list will also be updated based on the input directly, and it could be applied for every page with the search function. image

d33pspace commented 2 years ago

@AnKar112 Edward has a good point here. There is no dropdown style necessary. The list will update based on what is entered in the search field. Knowing this, are you able to make the updates to the necessary pages without Mariia's new design?

AnKar112 commented 2 years ago

Good idea. But I am confused a little - on page "Headers" in Figma we have two "Guest Lists" with a different design of search:

https://i.imgur.com/eUCOjBK.jpg https://i.imgur.com/bh46csW.jpg

And by the way, "Headers" page becoming very huge, let's stop using it. It becoming hard to find something there.

d33pspace commented 2 years ago

@AnKar112 Sorry about the confusion, this is the correct one which can serve as the template for guest_list, start_the_service and user_list. I agree about the "Headers" page becoming too huge. I will pass on that feedback to Mariia.

bh46csW

AnKar112 commented 2 years ago

Done, take a look.

d33pspace commented 2 years ago

@AnKar112 Fantastic!