search

d33pspace / Renewal-Design-Html

0 stars 0 forks source link

Change report icon colors #82

Closed d33pspace closed 2 years ago

d33pspace commented 2 years ago

Hi @MariiaBubley ...

Just a tiny change here. We need to reverse the color of the icons and text for increase and decrease. In China red is the good color and green is the bad color, so increase here needs to be red, and decrease needs to be green. The same is true for the clocks on the same report, increase in time should be green (because that's bad), decrease in time should be red (good).

This change is only necessary because we need the bar graph icons in the new colors.

Screenshot 2022-04-13 145740

edwazhao commented 2 years ago

Hi @d33pspace , To your description

In China red is the good color and green is the bad color

From my point of view, it is not the case, green means good, red mean bad, @elainetao829 what your opinion? Same color used in notifications, green means success, and red means error, maybe just in IT world image

d33pspace commented 2 years ago

@edwazhao Ah. Interesting. I am thinking of stock market reports. Red numbers are good. Green numbers are bad. @elainetao829 What is your opinion for our reporting? My current opinion is for alerts, red is failure, green is success. For reporting, red is good, green is bad. I don't think it's confusing because the context is different. Hanson watches the stock market so he will also be used to this standard.

edwazhao commented 2 years ago

@d33pspace By the way, beside increase and decrease icons, do we need an equals icon? And what color for equals?

elainetao829 commented 2 years ago

I think there is no right and wrong. But since @d33pspace and Hanson will be the two major users (or maybe only users) of the report function, I would suggest we follow their instinct and suggestions.