d34dman / drupal-jsonapi-params

A package to manage json-api params
ISC License
59 stars 8 forks source link

Add options to getQueryString(options) #13

Closed signalwerk closed 3 years ago

signalwerk commented 3 years ago

Pass on the options to qs.stringify

This is not breaking since it's optional and the default behaviour is not changed. MINOR in Semantic Versioning

I refactored all the test to not include the encoding and add an additional encoding test if no options are passed to the function ( see → Filter for text = "\/ []&?" URI encoded in src/__tests__/PackUnpackString.test.ts)

d34dman commented 3 years ago

Hi @signalwerk,

Thanks for the Pull request. Much appreciated.

I like this idea and have no problem in merging it.

TODO

Let me know if you are interested in adding them. If not, then I plan to work on this in the weekend.


P.S. I mistook you for my colleague Stephan Huber (from Hamburg Germany).

signalwerk commented 3 years ago

@d34dman not sure what test you are asking to do. I think I added a test without options. But since I mention it in my first post you are probably speaking about something else. Can you help me here? Did you see that?

d34dman commented 3 years ago

@signalwerk sorry for the confusion, I think I was blinded by the pure awesomeness of the pull request. Thank you!

signalwerk commented 3 years ago

@d34dman 😂 thank you for the merge and the compliment. and of course; thank you for the package.

d34dman commented 1 year ago

Hi @signalwerk , I was wondering you have a Drupal.org profile. I would like to give credits for contributing to this feature on Drupal.org as well.

signalwerk commented 1 year ago

@d34dman yes. I do have a profile. It's also called signalwerk. Thank you.

d34dman commented 1 year ago

Done :)

signalwerk commented 1 year ago

@d34dman thank you! nice 🥳