Closed signalwerk closed 3 years ago
Hi @signalwerk,
Thanks for the Pull request. Much appreciated.
I like this idea and have no problem in merging it.
TODO
getQueryString
without option. This should also double as regression test.Let me know if you are interested in adding them. If not, then I plan to work on this in the weekend.
P.S. I mistook you for my colleague Stephan Huber (from Hamburg Germany).
@d34dman not sure what test you are asking to do. I think I added a test without options. But since I mention it in my first post you are probably speaking about something else. Can you help me here? Did you see that?
@signalwerk sorry for the confusion, I think I was blinded by the pure awesomeness of the pull request. Thank you!
@d34dman 😂 thank you for the merge and the compliment. and of course; thank you for the package.
Hi @signalwerk , I was wondering you have a Drupal.org profile. I would like to give credits for contributing to this feature on Drupal.org as well.
@d34dman yes. I do have a profile. It's also called signalwerk. Thank you.
Done :)
@d34dman thank you! nice 🥳
Pass on the options to qs.stringify
This is not breaking since it's optional and the default behaviour is not changed.
MINOR
in Semantic VersioningI refactored all the test to not include the encoding and add an additional encoding test if no options are passed to the function ( see →
Filter for text = "\/ []&?" URI encoded
insrc/__tests__/PackUnpackString.test.ts
)