search

d365collaborative / d365fo.tools

Tools used for Dynamics 365 Finance and Operations
MIT License
250 stars 102 forks source link

get-d365installedhotfix not listing any hotfixes #313

Closed JoPe72 closed 2 years ago

JoPe72 commented 5 years ago

I have a 10.0.4 with an added package of quality hotfixes. When i run get-d365installedhotfix I do not get a list of installed hotfixes back. There is no error message but there is no result either.

FH-Inway commented 3 years ago

@Splaxi I wonder if this cmdlet is still relevant. The addins function that @Ievgenm describes in their blog does not seem to exist anymore. I think hotfixes in this sense may have been something from the pre one version era.

Splaxi commented 3 years ago

@FH-Inway

I believe you are correct. We had a brief discussion way back with Joris and he stated the same thing.

Should do a refactor and remove them, so we only have used / valid cmdlets available?

FH-Inway commented 3 years ago

@Splaxi No arguments against removal from me, our projects are all on one version. But I hear there are still environments out there that are not (probably mostly on premise). Do you have any indication if the d365fo.tools are used on those?

Instead of removing, we could improve the cmdlets documentation to let users know that it is intended for older versions. But I'm not sure if it is worth the effort. Maybe the tools should have some sort of deprecation warning?

Splaxi commented 3 years ago

I'm favor for deprecation warnings.

Let's settle for 6 months.

The tools are not used to much, as they have other other tools (public) from other community members.

Would you take a swing at a PR?

FH-Inway commented 3 years ago

Sounds good and yes, I will create a PR.

FH-Inway commented 3 years ago

@Splaxi Turns out that there is only an obsolete attribute for parameters, but not for cmdlets (at least not for ones that are written in a PowerShell function/script - seems you can also write them as C# classes/methods?). I created PR #578 with updates to the documentation and a small guide in case we want to deprecate other cmdlets in the future, let me know if you want any changes.

Ievgenm commented 3 years ago

Im not 100% sure that it is obsolete. ER takes dependencies on HF installed so it checks if they are installed or not. I need to look into it and see what it does.

Splaxi commented 3 years ago

@Ievgenm Any news to share with us? 😉

Ievgenm commented 3 years ago

Gave it a quick look and did not find anything useful, so probably just deprecate it.

Splaxi commented 2 years ago

Closing because of age