search

d3atiq / netplan-networking

An Ansible role for network interface configuration in Ubuntu 18.04
MIT License
7 stars 6 forks source link

Fix handlers trigger #2

Closed ashapiatsiuk closed 5 years ago

ashapiatsiuk commented 5 years ago

Thank you for this great module. Moving netplan apply to handlers will trigger it only in case of any changes of the configurations. In current state it's triggered on each ansible execution. Having systemd-resolved and networkd doesn't work in my test env and i'm not sure why do you trigger it.

d3atiq commented 5 years ago

Hi ashapiatsiuk,

Thanks for your contributions. I could not recall why I didn't simply call netplan apply in the handler as you suggested, but I think I had some issue with the first releases of Ubuntu 18.04. Anyway, I am not using netplan in my current work, so I will just accept your suggestion and as I have a chance I will go through this. For now, I have incorporated your changes not by direct merging (as that would have killed my existing work) but by adding a new handler and commenting the others out for now. If you have a chance to use this new role version, please let me know if it solved your issues, ok?

Cheers!