d3b-center / OpenPedCan-analysis

The analysis repository for the Open Pediatric Cancer Project
https://d3b-center.github.io/OpenPedCan-analysis/
Other
16 stars 14 forks source link

Analysis update: Add embryonal workflow to README #463

Closed zzgeng closed 11 months ago

zzgeng commented 11 months ago

Purpose/implementation Section

What scientific question is your analysis addressing?

Add embryonal workflow to README

What was your approach?

Add embryonal workflow to README

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

embryonal workflow

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

Documentation Checklist

zzgeng commented 11 months ago

criteria listed in the README is TTYH1 fusion but in the image that is depicted until the third layer of nodes. I would suggest moving all the pathology information first, since that comes first in the figure. I also think there are some criteria missing in the README such as the possibilities involving LIN28A, FOXR2 or chr19 amplification. Also, the definitions of the subtypes "EMTR, C19MC0altered", "ETMR, NOS" etc are missing from the text description. As for specific comments on the layout of the figure

Thank you for your suggestions! I have made changes to the figure to make it more readable. I also added a chunk of text in README to briefly describe how the molecular subtyping is performed. Please take a look when you have time and let me know if any update is needed.