d3b-center / OpenPedCan-analysis

The analysis repository for the Open Pediatric Cancer Project
https://d3b-center.github.io/OpenPedCan-analysis/
Other
15 stars 13 forks source link

D3b Bix Dev Feature: Fix bug #552

Closed migbro closed 4 months ago

migbro commented 4 months ago

[Required] Is this a new tool/workflow?

No

[Required] Which tools/workflows would you like to update/add?

Provide software links and dockerPull location if applicable

analyses/collapse-rnaseq/cwl/scripts/liftover_collapse_rnaseq.py

[Required] What features (new params, inputs, outputs, etc) would you like to add to each?

Add reference files and test input locations if applicable

return happens too soon, causing all duplicate genes to be collapsed to be dropped, except one, in https://github.com/d3b-center/OpenPedCan-analysis/blob/a78b0e3fd711bcea2ed83fc0e950872a2065221b/analyses/collapse-rnaseq/cwl/scripts/liftover_collapse_rnaseq.py#L63-L71

[Optional] How long do you think this work will take?

an hour

[Optional] Who will complete this work?

@migbro

Ticket will be considered resolved either by a successful PR with updated release if applicable, or a simple denial of the request backed by a good reason

jharenza commented 4 months ago

completed with #553