d3b-center / OpenPedCan-analysis

The analysis repository for the Open Pediatric Cancer Project
https://d3b-center.github.io/OpenPedCan-analysis/
Other
15 stars 14 forks source link

🐛 Fix Collapse bug #553

Closed migbro closed 7 months ago

migbro commented 7 months ago

:wrench: fixed collapse bug

Purpose/implementation Section

What scientific question is your analysis addressing?

A bug fix in collapse gene logic, and issues with package availability in docker pull

What was your approach?

Look at the code, identify the cause

What GitHub issue does your pull request address?

The return for the function was happening inside loop, instead of returning after the loop completed, resulting on in only one duplicate gene being collapsed and all others being dropped. Also changes one of the step to pull from annoFuse docker instead of tidyverse to make required optparse package readily available

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Updates to python script and results from https://cavatica.sbgenomics.com/u/d3b-bixu-ops/open-target-tcga-rnaseq-counts/tasks/6f6651b8-850d-4cfc-96fe-467f1b4b455a/

Is there anything that you want to discuss further?

Address #550 #552 #551

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

Outputs from https://cavatica.sbgenomics.com/u/d3b-bixu-ops/open-target-tcga-rnaseq-counts/tasks/6f6651b8-850d-4cfc-96fe-467f1b4b455a/

What is your summary of the results?

Reproducibility Checklist

Documentation Checklist

jharenza commented 7 months ago

Merging this since this is not run in GA