d3b-center / OpenPedCan-analysis

The analysis repository for the Open Pediatric Cancer Project
https://d3b-center.github.io/OpenPedCan-analysis/
Other
15 stars 13 forks source link

MB SHH subtyping #565

Closed rjcorb closed 2 weeks ago

rjcorb commented 3 months ago

Purpose/implementation Section

What scientific question is your analysis addressing?

Closes #564. This PR pulls all molecular alterations associated with specific Medulloblastoma SHH subtypes in all MB SHH samples, and classifies samples first based on methylation subtyping and then by age and molecular criteria from this review

What was your approach?

SHH subtypes are currently classified based on the following criteria:

There are currently no additional criteria to classify samples as SHH-gamma

What GitHub issue does your pull request address?

564

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Please review all code and specifically the logic to classify subtypes. Is this consistent with the literature? Are there other molecular alterations we should be considering?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

mb_shh_subtype_summary.csv

What is your summary of the results?

Reproducibility Checklist

Documentation Checklist

jharenza commented 3 months ago

Adding some comments from discussion with Sebastian:

Major criteria: DNA methylation-based subtyping into alpha, beta, gamma, delta Minor criteria: Alpha: 3-21 yo, TP53 (som/ger), ELP1 (som/ger), MYCN/GLI2/CCND2 (amp), isochromosome 9p, -17p, -3p Beta: <5 yo, SUFU (som/ger), KMT2D, +2, cnLOH 10q Gamma: <5 yo, no +2p Delta: 10-65, >95% U1 snRNA (RNU1–1, RNU1–2, RNU1–3, and RNU1–4), TERT, DDX3X

jharenza commented 2 months ago

hi @rjcorb can you stack the MB PRs on https://github.com/d3b-center/OpenPedCan-analysis/pull/571? I had to remove MM2S code there.

jharenza commented 1 month ago

hi @rjcorb I haven't pulled this up, but I suspect the error you have is perhaps due needing to unzip the file in R before pulling up the file, since it is only available in zip format in the release. There is a way to read in and unzip contents so you can pull that file.

Error: '/github/workspace/data/cnv-consensus-gistic/broad_values_by_arm.txt' does not exist.

rjcorb commented 1 month ago

@jharenza thanks, this should be resolved now