d3b-center / OpenPedCan-analysis

The analysis repository for the Open Pediatric Cancer Project
https://d3b-center.github.io/OpenPedCan-analysis/
Other
15 stars 13 forks source link

Module contribution counts #573

Closed jharenza closed 1 month ago

jharenza commented 2 months ago

Purpose/implementation Section

What scientific question is your analysis addressing?

To come up with author order for this, adding a count contributions module

What was your approach?

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

Documentation Checklist

rjcorb commented 1 month ago

@jharenza I am getting one difference in total_contributions_clean.tsv after running locally:

< Jo Lynne Rokita   1015
---
> Jo Lynne Rokita   1013

(first count is local result)

jharenza commented 1 month ago

per slack convo with @rjcorb we each now got 1025 for total contributions for JLR, so will merge. Does not run in GHA.