d3b-center / OpenPedCan-analysis

The analysis repository for the Open Pediatric Cancer Project
https://d3b-center.github.io/OpenPedCan-analysis/
Other
18 stars 14 forks source link

Undo cancer_group manual override for select sample_ID as per OPC_566 #600

Closed sangeetashukla closed 3 months ago

sangeetashukla commented 4 months ago

Purpose/implementation Section

Fix cancer_group and subtype mismatch for BS_YZD4SSMA

What scientific question is your analysis addressing?

There was a manual hard-coding of cancer_group for a specific sample_id. This caused the cancer_group and subtype mismatch. I investigated the source to fix the mismatch.

What was your approach?

Review the molecular-subtyping-integrate module to investigate the values in the input data sources Review the KF_BS 'BS_YZD4SSMA' to locate manual override. Undo such hardcoding, and review the result files to confirm cancer_group and subtype match.

What GitHub issue does your pull request address?

Issue 566

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Please review the result files to confirm the data for 'BS_YZD4SSMA' is acceptable.

Is there anything that you want to discuss further?

No.

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes.

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

Documentation Checklist

jharenza commented 3 months ago

merging since the relevant module passed