Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Please double check the following:
1) Do we like the color for "Not done"?
2) Is it right to use the OpenPBTA output?
3) Looks like mutation_status only has "Normal" (TMB <10).
Also note that this is a staggered PR, so would clean up once the re-run PR is merged.
Is there anything that you want to discuss further?
No.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes.
Results
What types of results are included (e.g., table, figure)?
New oncoprint plot
What is your summary of the results?
NA.
Reproducibility Checklist
[ ] The dependencies required to run the code in this pull request have been added to the project Dockerfile.
[ ] This analysis has been added to continuous integration.
Documentation Checklist
[ ] This analysis module has a README and it is up to date.
[ ] This analysis is recorded in the table in analyses/README.md and the entry is up to date.
[ ] The analytical code is documented and contains comments.
Purpose/implementation Section
What scientific question is your analysis addressing?
Modified oncoprint to: 1) Modified
NA
toNot done
2) Addedmutation_status
annotation as indicated in https://github.com/d3b-center/Cole-telomere-analysis/issues/16What was your approach?
1) for modifying NA:
2) For adding TMB, I used TMB from
OpenPBTA-analysis/analyses/tmb-compare/TMB_d3b_code/outputs/pbta-snv-consensus-TMB_intarget.txt
and usedWhat GitHub issue does your pull request address?
https://github.com/d3b-center/Cole-telomere-analysis/issues/16
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Please double check the following: 1) Do we like the color for "Not done"? 2) Is it right to use the OpenPBTA output? 3) Looks like
mutation_status
only has "Normal" (TMB <10).Also note that this is a staggered PR, so would clean up once the re-run PR is merged.
Is there anything that you want to discuss further?
No.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes.
Results
What types of results are included (e.g., table, figure)?
New oncoprint plot
What is your summary of the results?
NA.
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.