Closed runjin326 closed 2 years ago
I think at one point, I asked Jenny and she mentioned that alt_final is the column we should use. Hence, started this PR against re-run 04.
alt_final
Modify alt final to all upper case column alt_final - and instead of using phenotype, we use alt_final.
alt final
phenotype
NA
Please double check to make sure we want to use alt_final
No.
Yes.
Figures:
all-pbta-by-subgroup.pdf all-pbta.pdf hgat.pdf non-hgat.pdf
The results are consistent with the results when we use phenotype.
README
analyses/README.md
Oh yes, thanks for catching that!
Purpose/implementation Section
What scientific question is your analysis addressing?
I think at one point, I asked Jenny and she mentioned that
alt_final
is the column we should use. Hence, started this PR against re-run 04.What was your approach?
Modify
alt final
to all upper case columnalt_final
- and instead of usingphenotype
, we usealt_final
.What GitHub issue does your pull request address?
NA
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Please double check to make sure we want to use
alt_final
Is there anything that you want to discuss further?
No.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes.
Results
What types of results are included (e.g., table, figure)?
Figures:
What is your summary of the results?
The results are consistent with the results when we use
phenotype
.Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.