d3b-center / PBTA-ALT-analysis

Repository for CBTTC-ALT project with Kristina Cole
MIT License
4 stars 0 forks source link

Use `alt final` instead of phenotype #38

Closed runjin326 closed 2 years ago

runjin326 commented 2 years ago

Purpose/implementation Section

What scientific question is your analysis addressing?

I think at one point, I asked Jenny and she mentioned that alt_final is the column we should use. Hence, started this PR against re-run 04.

What was your approach?

Modify alt final to all upper case column alt_final - and instead of using phenotype, we use alt_final.

What GitHub issue does your pull request address?

NA

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Please double check to make sure we want to use alt_final

Is there anything that you want to discuss further?

No.

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes.

Results

What types of results are included (e.g., table, figure)?

Figures:

all-pbta-by-subgroup.pdf    
all-pbta.pdf            
hgat.pdf            
non-hgat.pdf

What is your summary of the results?

The results are consistent with the results when we use phenotype.

Reproducibility Checklist

Documentation Checklist

jharenza commented 2 years ago

Oh yes, thanks for catching that!