d3b-center / PBTA-ALT-analysis

Repository for CBTTC-ALT project with Kristina Cole
MIT License
4 stars 0 forks source link

add command line option for oncokb annotation #62

Closed rjcorb closed 2 years ago

rjcorb commented 2 years ago

Purpose/implementation Section

Update 09-lollipop analysis module so that OncoKB access token is provided in command line when running analysis module.

What scientific question is your analysis addressing?

NA

What was your approach?

What GitHub issue does your pull request address?

Ticket #59

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

No

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

MAF subset tables: hgat-goi.maf.tsv snv-dgd-goi.maf.tsv

OncoKB annotation results: dgd_maf-goi-oncokb.tsv snv-consensus-plus-hotspots-hgat-oncokb.maf.tsv

Lollipop plots: atrx-lollipop-all.pdf atrx-lollipop-alt-neg.tiff atrx-lollipop-alt-pos.tiff atrx-lollipop-comp.tiff atrx-lollipop-oncogenic.pdf atrx-lollipop-vus.pdf

What is your summary of the results?

The atria-lollipop-comp.tiff plot now includes one additional sample in the ALT- group (N=47 vs N=46 previously).

Documentation Checklist

jharenza commented 2 years ago

Script 01 runs fine for me, but I am getting an error with script 2:

Traceback (most recent call last):
  File "/home/oncokb-annotator/MafAnnotator.py", line 7, in <module>
    from AnnotatorCore import setsampleidsfileterfile
  File "/home/oncokb-annotator/AnnotatorCore.py", line 5, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'

My token is still valid, so I am not sure if I don't fully have the oncokb annotator fully installed in the docker image somehow. Assuming this worked fine for you in docker?

rjcorb commented 2 years ago

I just checked and there are two dependencies not installed in the docker image. I believe I installed them while in the docker container, hence why it isn't reproducible currently.

jharenza commented 2 years ago

Perfect, thanks - will update the dockerfile in a separate PR - I just looked over there and missed the "common" ones when checking!