d3b-center / PBTA-ALT-analysis

Repository for CBTTC-ALT project with Kristina Cole
MIT License
4 stars 0 forks source link

update jenny's file #7

Closed jharenza closed 3 years ago

jharenza commented 3 years ago

Purpose/implementation Section

What scientific question is your analysis addressing?

update jenny's file merge after #6

What was your approach?

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

Documentation Checklist

jharenza commented 3 years ago

@runjin326 I updated this with jenny's new file, but there are two issues here:

  1. DNA and RNA BS_id matchs did not consider parent_aliquot_id, so please match on those prefixes and remove the non-matching
  2. we need to use independent specimens here for DNA sample_id - we can either do a sampling or use independent specimens in OpenPBTA if there is a file that spanstumor_descriptor`

Can you work on those two things? Thanks!

runjin326 commented 3 years ago

@jharenza , so do you want me to work on this after the PR is merged? Or just directly commit on the PR?

jharenza commented 3 years ago

You can directly commit bc this is upstream of the rest

jharenza commented 3 years ago

should we go ahead and swap those in the input file?

Yes please. I think this happened before we had those longer parental aliquot IDs to match with, so all dna and rna were matched.