d3cim / dnscrypt-proxy-android

Hardened dnscrypt-proxy module for Android.
GNU General Public License v3.0
108 stars 15 forks source link

Module's uninstall doesn't work as it should #1

Open d3cim opened 2 years ago

d3cim commented 2 years ago

Describe the bug DNSCrypt module doesn't remove the internal dnscrypt-proxy folder once removed from Magisk.

To Reproduce Steps to reproduce the behavior:

  1. Download the latest dnscrypt-proxy-android version
  2. Disable network connections (no internet)
  3. Install the .zip downloaded
  4. Reboot
  5. Open Magisk > Modules > DNSCrypt-Proxy 2 > Remove
  6. Reboot
  7. See dnscrypt-proxy folder still at storage/emulated/0/dnscrypt-proxy path

Expected behavior (i.e. solution) Once removed the module should remove all of its rests, without leaving the dnscrypt-proxy folder in the internal memory.

Device informations:

Additional context

What I know

What I don't know

cypherpunk1984 commented 2 years ago

I think it is supposed to work that way, a lot of apps and magisk modules leave behind their folders in storage/emulated/0/, because most of the times there are config files that the user wants to keep in case they reinstall. It happens on Linux also, whenever you uninstall a package/app, even if you force the command to clean everything, most of the time they leave folders behind in /home/[user]/.config or /home/[user]/.local, with config files, databases, etc. The next time you reinstall the software, you don't need to set it up. And it is always just a couple of kilobytes of data, so no biggie. You can always remove them manually though.

d3cim commented 2 years ago

I understand, what has been described is plausible but it cannot be so because the configuration files are not moved into any hidden folder, moreover the demonstration is that on devices with Android 7 or lower it works. It is almost certainly due to the fact that the device keeps its content encrypted until it is completely unlocked and the script does not work correctly in its current state.