d3dcoder / d3d12book

Sample code for the book "Introduction to 3D Game Programming with DirectX 12"
1.51k stars 583 forks source link

4X MSAA fails #16

Open jcroskery opened 6 years ago

jcroskery commented 6 years ago

In d3dapp.h, there is a Boolean variable called m4xMsaaState, which is set to false. Setting this variable to true will cause the application to terminate with a bad HRESULT when it tries to create the swap chain. According to this Stack Overflow post, creating a MSAA swap chain will not work in DirectX 12, which is what setting this variable to true tries to do. Therefore, I think that you should fix this problem or at least create a comment in the code saying why setting this Boolean variable to true will not work as expected. Thank you!

P.S. I know that there has been other discussions about this issue but since the issue has not been solved, I thought I'd open this issue. EDIT: Pressing f2 also crashes the applications for the same reason.

hermestrimegistus commented 6 years ago

Thanks for contribution.

Zydiii commented 1 year ago

Thanks for the information. I have encountered with the same problem > <