d3fend / d3fend-ontology

This repository holds the necessary content to produce the D3FEND ontology distribution.
https://d3fend.mitre.org
MIT License
53 stars 22 forks source link

Add network "Basic Signature Analysis" and "Advanced Signature Analysis" - fix #218 #229

Closed 2xyo closed 2 months ago

2xyo commented 2 months ago

This Pull Request resolves issue https://github.com/d3fend/d3fend-ontology/issues/218 by adding"Basic Signature Analysis" and "Advanced Signature Analysis".

netfl0 commented 2 months ago

Thank you!

We will need concrete references added as well, this is essential to make sure we've named things properly. Are you interested in providing those?

One note on advanced versus basic, we're more likely to describe that aspect of (Traffic Signature Analysis, Network Signature Analysis, Network Traffic Signature Analysis) using the D3FEND ACF rather than putting it in the name itself. CC @hack-sentinel

2xyo commented 2 months ago

A more "academic" version could be just "Signature Analysis" https://gist.github.com/2xyo/054b1ed37958e3a7ce1be172c981e06d

Which could be at least be implemented with d3f:LogicalRules and "Imperative programming". Not found in ACF.

netfl0 commented 2 months ago

OK, lets collapse these into Network Traffic Signature Analysis

Would you like to push an updated request, or would you like us to make the changes?

Also, would you like to be listed as a contributor, if so which format do you prefer:

The format will be:

Firstname Lastname [– Organization] [- @handle]

(optional Organization and handle)

2xyo commented 2 months ago

Thanks, I just updated my PR. I would be happy to be listed for my modest contribution as "Yohann Lepage - EDF"

netfl0 commented 2 months ago

Thank you @2xyo !!