search

d3george / slash-admin

A modern react admin. It is based on react 18, vite and TypeScript. It's fast !
https://admin.slashspaces.com/
MIT License
1.49k stars 218 forks source link

fix: docker build failure #59

Closed iutx closed 3 months ago

iutx commented 3 months ago

Build will cause the following error:

ERROR: This version of pnpm requires at least Node.js v18.12
14.92 The current version of Node.js is v16.20.2

Default install pnpm(version 9) need node > = v18.12. Keep the version consistent with github ci.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
slash-admin ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 2:16am
d3george commented 3 months ago

We should find a way to upgrade instead of downgrading

iutx commented 3 months ago

We should find a way to upgrade instead of downgrading

Yes, upgrading to a new version is necessary.

I tried tested build and running on node v22.x with pnpm v9.x. image

It makes sense to specify pnpm version, reducing the problems of dynamic changes, it's like specifying the nodejs version.

Any ideas for further discussion.

@d3george PTAL :)

d3george commented 3 months ago

you can update pnpm and node version in Dockerfile and ci.yml

we have a Discord channel, you can join our channel, so that we can discuss more easily

iutx commented 3 months ago

you can update pnpm and node version in Dockerfile and ci.yml

we have a Discord channel, you can join our channel, so that we can discuss more easily

Okay, done, it appears that the CI does not fire again. I'll join Discord channel later ❤️.