search

d3lm / ngx-drag-to-select

A lightweight, fast, configurable and reactive drag-to-select component for Angular 10 and beyond
https://www.npmjs.com/package/ngx-drag-to-select
MIT License
293 stars 64 forks source link

feat(lib): add disabled state for select item #130

Closed ennjin closed 3 years ago

ennjin commented 3 years ago

Closes #71

ennjin commented 3 years ago

@d3lm Hey. Can you take a look at this, please?

ennjin commented 3 years ago

Hi. I've updated the notes above :)

ennjin commented 3 years ago

@d3lm We're blocked by these changes, can you take a look at this as well?

d3lm commented 3 years ago

Please rebase the PR on latest master. I have fixed CI.

ennjin commented 3 years ago

@d3lm Done

ennjin commented 3 years ago

There're latest changes from master branch.

ennjin commented 3 years ago

Updated!

d3lm commented 3 years ago

Merged! Thanks a lot for this PR 🙏

ennjin commented 3 years ago

@d3lm Thanks! I'm wondering if could you bump the new changes to the NPM?

d3lm commented 3 years ago

Definitely. I am trying to push on the other PR too so I can cut a single release that includes both new features.

d3lm commented 3 years ago

It's this one #129.

d3lm commented 3 years ago

I am not hearing anything, so maybe we can cut a release already. Alternatively you could pick up the PR and we can get it over the finish line.

ennjin commented 3 years ago

I am not hearing anything, so maybe we can cut a release already

Yep, it would be nice if we released it

ennjin commented 3 years ago

So, will you bump the new version?

UPD: @d3lm ping

d3lm commented 3 years ago

It's now published. You can grab 4.2.0.