search

d3lm / ngx-drag-to-select

A lightweight, fast, configurable and reactive drag-to-select component for Angular 10 and beyond
https://www.npmjs.com/package/ngx-drag-to-select
MIT License
293 stars 65 forks source link

fix(lib): keep selection when selectableItems change (#139) #142

Closed lemmywrap closed 2 years ago

lemmywrap commented 3 years ago

Pull request which fixes #139

d3lm commented 3 years ago

Nice! Thanks for this PR 🙏 Really appreciate it 💯

lemmywrap commented 3 years ago

Happy to contribute :) I've added the newlines.

lemmywrap commented 3 years ago

Hi @d3lm, any idea when you'll be able to take a look at this, and hopefully accept the pull request?

d3lm commented 3 years ago

Oh sorry, totally forgot about this. I ll have a look over the weekend so we can get this in. Thanks for reminding me 🙏

lemmywrap commented 3 years ago

Two weekends later... 😉 I'll just keep reminding you, @d3lm !

gavinharriss commented 2 years ago

Looks like a fix I could use as well. can't work out why the pull request isn't merged though?

TheGlockZentix commented 2 years ago

Would be awesome if we could get this merged @d3lm! ⭐

d3lm commented 2 years ago

Ok, I have done some general maintenance over the weekend and finally merged this PR. Thanks for collaborating!

d3lm commented 2 years ago

For your information, this is available in v4.2.1 and it's published to npm.