search

d3lm / ngx-drag-to-select

A lightweight, fast, configurable and reactive drag-to-select component for Angular 10 and beyond
https://www.npmjs.com/package/ngx-drag-to-select
MIT License
293 stars 64 forks source link

Mobile support like for desktop #162

Open RoopeHakulinen opened 2 years ago

RoopeHakulinen commented 2 years ago

Thanks @d3lm for this well-written, maintained, and documented library.

As I understand it based on the docs and trying it out, the support for mobile is implemented by means different from those used on the desktop. For my use case, the mobile support should reflect what's available on the desktop. As such, I went ahead and implemented it by using touch events over mouse events, and it seems to work fine (on Chrome mobile emulation mode, anyways).

Would you be up for merging in a PR to implement a touch event-based approach for mobile usability similar to one on desktop? I could draft one after some more testing if it actually works.

d3lm commented 2 years ago

Hey there 👋 Thanks for reaching out, and I am glad to hear you like this library and find it useful.

That's a good point you bring up and I do think it does make sense to integrate touch events for mobile. A PR is more than welcome 🙏 If you push a draft we can iterate on it and I can provide feedback.