d3plus / d3plus-react

React components for d3plus visualizations.
MIT License
31 stars 6 forks source link

visualizations no longer setting default className to viz #21

Closed jspeis closed 6 years ago

jspeis commented 6 years ago

Was trying to chase an issue down with some weird styling that broke after an upgrade. Looks like the CSS in the project was relying on having d3plus visualizations like <Geomap> get wrapped by default in a class with the name viz. But seems like that is no longer the default behavior.

Possible cause might be even though Viz.js sets defaultProps with className: "viz" it looks like other instances e.g. Geomap wipe that out by overwriting the default props on the class: Geomap.defaultProps = {type};

davelandry commented 6 years ago

Fixed with #22