fixes defaultProps for children of Viz class #21 - Githubissues

d3plus / d3plus-react

React components for d3plus visualizations.

MIT License

31 stars 6 forks source link

fixes defaultProps for children of Viz class #21 #22

Closed jspeis closed 6 years ago

jspeis commented 6 years ago

Fixes the way defaultProps for children of Viz class get set, fixing #21

Description

Instead of overwriting the defaultProp, this uses Object.assign to "inherit" the parent Viz class's defaultProps.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Notes

The spread operator ... doesn't seem to work with the current buble configuration for this package?