Added support for aria-label #78 and role #79 attributes.

[rbaheti]

Description

aria-label #78:

• assigned default value in the constructor
• assigned aria-label attribute to this._enter variable
• created a user-accessible method, ariaLabel, to change the value closes #78

role #79 :

• assigned default value in the constructor
• assigned aria-label attribute to this._enter variable
• created a user-accessible method, role, to change the value closes #79

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• [x] I have documented all new methods.
• [ ] I have written tests for all new methods/functionality.
• [x] I have written examples for all new methods/functionality.

[rbaheti]

Great, thanks!

-Rashmi

On Fri, Jun 8, 2018 at 1:34 PM, Dave Landry notifications@github.com wrote:

@davelandry requested changes on this pull request.

@rbaheti https://github.com/rbaheti this looks great! only 2 minor comments to be addressed.

also, in the main body of this PR, if you edit the text so that the word "closes" appears before the issue numbers (ie. closes #78 https://github.com/d3plus/d3plus-shape/issues/78) then the issue will be automatically closed when I merge the PR 😎

https://help.github.com/articles/closing-issues-using-keywords/

In src/Shape/Shape.js https://github.com/d3plus/d3plus-shape/pull/81#discussion_r194129071:

@@ -74,6 +75,7 @@ export default class Shape extends BaseClass { this._name = "Shape"; this._opacity = constant(1); this._pointerEvents = constant("visiblePainted");

• this._role = "presentation";

make the default value use the constant function: this._role = constant("presentation");

In src/Shape/Shape.js https://github.com/d3plus/d3plus-shape/pull/81#discussion_r194129160:

@@ -44,6 +44,7 @@ export default class Shape extends BaseClass { return s * 3; } };

• this._ariaLabel = "";

make the default value use the constant function: this._ariaLabel = constant("");

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/d3plus/d3plus-shape/pull/81#pullrequestreview-127250473, or mute the thread https://github.com/notifications/unsubscribe-auth/AJAu_OE0IuwLuuBgqFuh9LVki6qU7mEKks5t6rWOgaJpZM4Ugoj- .