Box shape#65 - Githubissues

d3plus / d3plus-shape

Fancy SVG shapes for visualizations

MIT License

20 stars 2 forks source link

Box shape#65 #82

Closed rbaheti closed 6 years ago

rbaheti commented 6 years ago

Description

Adds new shapes Box and Whisker to d3plus-shape. closes #65

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] I have documented all new methods.
[ ] I have written tests for all new methods/functionality.
[ ] I have written examples for all new methods/functionality.

davelandry commented 6 years ago

Additionally, the whiskerMode method on Box seems to be working incorrectly:

when the user passes an Array with 2 different values (ie. ["tukey", "extent"]), the first value in the array should be used for the lower-valued whisker, and the second value should be used for the higher-value whisker (it seems that they are backwards currently)
the logic for Numbers is not working. when setting .whiskerMode([0.1, 0.9]), the lower-valued whisker should be calculated at the 10th percentile, and the higher-valued whisker should be calculated at the 90th percentile

davelandry commented 6 years ago

And finally, I found the following CSS that draws a 10px grid in the background of the page to help test placement 😎

body {
  background-size: 10px 10px;
  background-image: linear-gradient(to right, #ddd 1px, transparent 1px), linear-gradient(to bottom, #ddd 1px, transparent 1px);
  margin: 0;
}