Predict .messages() visibility based on size of dataset

d3plus / d3plus

A javascript library that extends D3.js to enable fast and beautiful visualizations.

MIT License

1.63k stars 188 forks source link

Predict .messages() visibility based on size of dataset #52

Closed fernoftheandes closed 10 years ago

fernoftheandes commented 10 years ago

Hi Dave,

I am assuming you are outputting this string in case it is a large dataset or perhaps a slow computer, not sure. But in cases where the display is fast, one sees this "message" flashing on the screen every time one clicks on a node to make it the focus ring. Not necessarily a pleasant thing...what do you think?

(Rings is getting really good. Putting a label on the focus ring was a good move.)

davelandry commented 10 years ago

This is a good point, it does look a little silly on apps with small datasets. For now, you can set .messages() to false to disable the messages.

I'm changing the title of this issue to reflect the need for a dynamic way for D3plus to internally detect whether or not the messages should be shown (probably based on the size of the dataset given to the visualization).

davelandry commented 10 years ago

Released v1.2.4 today that addresses this issue. From the release notes:

.messages() will only be displayed on initialization and for .draw() updates dealing with datasets that are over the "large" limits defined in both .data() and .edges().